Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to math for isnan #37

Closed
wants to merge 1 commit into from

Conversation

smathermather
Copy link

@smathermather smathermather commented Aug 16, 2024

Attempt to fix: OpenDroneMap/ODM#1796, #30

@smathermather smathermather marked this pull request as draft August 16, 2024 16:27
@smathermather
Copy link
Author

Hmm, it now completes instead of failing, but:

image

@smathermather
Copy link
Author

GNSS is really poor for that dataset, which is probably why it has GCPs. Switching testing to the dataset posted here:
https://community.opendronemap.org/t/error-processing-stopped-because-of-strange-values-in-the-reconstruction/21309

@pierotofy
Copy link
Member

I wouldn't use count on the reliability of the GCPs in sheffield park, I remember I used a pretty cheap device for capturing points.

@smathermather
Copy link
Author

😆 -- fair, though I think they're better than the drone positions.

I was hoping to use Sheffield Park for the speed of testing, but alas. Will revert to the (latest) original problem dataset and see where we get. Sadly, my fast machine is my machine with only 32GB RAM, so slow machine it it.

@smathermather
Copy link
Author

This is a deeper problem than this pull request can address: in the absence of Z, OpenSfM regularly fails in correctly guessing the orientation of the model / minimizing error with respect to rotation. The reason setting values to 0 works so well is it forces the model into something (typically) approaching the relatively even elevations across most folks scene. But doing so by default isn't (as Piero previously mentioned) the appropriate approach.

Until we can munge OpenMVS to handling model orientation better than it does, this will continue to be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting GCP to NaN often results in failed processing
2 participants