Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV V4.0: Pysical push button override #147

Closed
glynhudson opened this issue Feb 16, 2021 · 13 comments
Closed

DEV V4.0: Pysical push button override #147

glynhudson opened this issue Feb 16, 2021 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@glynhudson
Copy link
Collaborator

The physical push button should be able to override the charging timer to start or stop a charge

@jeremypoulter
Copy link
Collaborator

This should be done in the latest code

@glynhudson glynhudson changed the title DEV V4.0: Pysical push button overwride DEV V4.0: Pysical push button override Feb 24, 2021
@glynhudson
Copy link
Collaborator Author

I've just compiled and tested the latest version but the push button is still unresponsive. Does a vehicle need to be plugged in and a timer set for the button to do anything? Or should the button toggle between Ready > Sleeping > Ready states as before?

@glynhudson glynhudson added the bug Something isn't working label Feb 24, 2021
@jeremypoulter
Copy link
Collaborator

What OpenEVSE firmware are you using?

@glynhudson
Copy link
Collaborator Author

glynhudson commented Feb 25, 2021

Ah I had flashed the latest version to my home EVSE which is still running 7.0.1.
I'm now tested on my dev bench running 7.1.2 and the override buttons works 👍

It seems to work fine to toggle between Sleeping/Ready when no timer is set. However, if a timer is set and the EVSE is sleeping pushing the button once just displays "Manual override" but the EVSE stays sleeping. Pushing the button twice in quick succession starts charging momentarily before the EVSE returns to sleeping.

Another issue I've noticed is if the state is toggled using the push button and the LCD shows "manual override", if the state is then changed via the web interface the message "manual override" is still displayed on the LCD. To avoid confusion I don't think it's necessary to display the message "manual override" on the LCD since the push button is just another way the state can be changed e.g the web interface button can also be used to manually override a timer.

@jeremypoulter
Copy link
Collaborator

The web interface is still talking directly to the controller vi RAPI, this still needs updating to use the new priority system. I added the "Manual Override" text to let the user know that the automated behaviours (PV divert, timers, etc) are no longer functioning and the user has to hit the button again (or use the web interface), While this is slightly different than the existing behaviour it is needed to get some sanity out of multiple things trying to control the EVSE.

@glynhudson
Copy link
Collaborator Author

Sure, makes sense. Happy to keep the text it will probably make debugging customer issues easier!

This is still an issue in the latest version > If a timer is set and the EVSE is sleeping pushing the button starts charging momentarily before the EVSE returns to sleeping with "Sleeping | Manual Override" text on the LCD and subsequent button presses are ignored.

@glynhudson
Copy link
Collaborator Author

I've noticed an issue with the push button: if the push button is pressed to manually start a charging session the unit then remains in manual override mode even after this charging session has finished and all charging timers are ignored. There is no indication on the web UI that the unit is in manual override mode. I think the manual override mode should:

  1. Disable and return the normal mode when a charging session finishes (vehicle unplugged)
  2. It should be possible to disable manual override via the web UI and have an indication on the web UI if manual mode is active

Or an alternative would be just to get rid of manual override mode and just force the push button to toggle the state whatever mode is set and the EVSE would still honour charging timers e.g If a charging timer is set for 2pm-3pm but EV is plugged in a 1pm and the user presses the push button to start immediately the EV will charge from 1pm-3pm when it's stopped by the timer.

@jeremypoulter
Copy link
Collaborator

Sure, I am in the process of adding the API for the GUI to control the manual override, and also clear when the charge session finishes.

@glynhudson
Copy link
Collaborator Author

Thanks, please make this a priority. I've had two occasions now when my EV has failed to charge overnight via the charging timer since the manual override button has been used earlier in the day. As soon as charging finishes or there is any other state change manual override should be removed.

@jeremypoulter
Copy link
Collaborator

This should be resolved now

@chris1howell
Copy link
Member

A customer has suggested using the button to switch between Eco/Normal, this seems like a good idea if eco is setup and there are no timers active.

@glynhudson
Copy link
Collaborator Author

The push button is now working, however I've found it to be intermittent. Sometimes when a charge is active pushing the button just displays "manual override" on the LCD, but the charge does not stop, pushing the button a 2nd time is required to put the unit to sleep to stop a charge.

@glynhudson
Copy link
Collaborator Author

Here's a video example of the bug currently effecting the manual override button: https://photos.app.goo.gl/LinP5kXifs8aW4zd7

The button requires two presses, the first press just displays manual override but does not change the state, while the 2nd button press actually activates the override starting the charge in this case.

jeremypoulter added a commit that referenced this issue Jul 18, 2021
This makes sure the button knows the correct state when toggling. Fixes DEV V4.0: Pysical push button override #147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants