Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openevse shows GUI shows manual after sending DELETE override #654

Closed
rvoosterhout opened this issue May 22, 2023 · 16 comments
Closed

Openevse shows GUI shows manual after sending DELETE override #654

rvoosterhout opened this issue May 22, 2023 · 16 comments

Comments

@rvoosterhout
Copy link

OpenEVSE | 7.1.3
OpenEVSE Wifi | v4.2.2

Hello,

I'm trying to remove the manual mode by sending an powershell command to remove the manual mode. I can see on the screen that the manual mode dissapears, but the GUI still shows manual mode enabled. How can I remove the manual mode?

$response = Invoke-WebRequest -Uri 'http://192.168.1.8/override' -Method DELETE

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

what gui version do you have v1 ( old interface green one ) or v2 ( new interface, blue one ) ? ( firmware file ending by _gui-v1 or _gui-v2 )

@rvoosterhout
Copy link
Author

V2

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

I can see on the screen that the manual mode dissapears, but the GUI still shows manual mode enabled

Can you post a screen ? I don't get it

@rvoosterhout
Copy link
Author

I agree, I wasn't very clear. With the screen i meant the display on the openevse unit itself. The display shows manual override when you turn it to manual override. When I clear the manual override by sending the powershell command mentioned above, or I use node red using an http request DELETE node, it does change the display on the unit itself, but on the GUI it still shows manual mode. It doesn't switch to automatic mode (the little robot icon). Clearing the manual override by sending the DELETE command actually toggles the charger to Enabled on manual override. It doens't remove the manual override.
image

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

If you talk about the little tag on the bottom left of the status bar, it doesn't always means there's a manual override. If it is the default state, it will also display it is manual, if there's nothing else that control automatically the evse state. ( I could fix that and display somehting like "Default" )
It's because it considers it is in manual mode ( aka you have to click on charge or stop to trigger the action you want. )

If you want to check the claims/override go in monitoring/commands tab and you will see if there's one running.

@rvoosterhout
Copy link
Author

rvoosterhout commented May 22, 2023

The strange thing is, I used to have the 3rd middle button looking like a robot, where I could choose to have openevse automaticly decide what to do.
Let me also explain my situation. I'm using Node Red to disable the charger when i'm not home to prevent other people using it by sending an http request with the payload {"state": "disabled"} to enable the manual override and disable the charger. That works. But I want to disable the manual override when I get home and let openevse use the automatic mode with the shaper, but that doesn't seem to work.
In the following screenshot, I sent the http request DELETE to disable manual override, but it does the opposite, it activates the manual override without showing anything in Monitoring - commands
image

Using powershell gives me the following error:
Invoke-WebRequest : {"msg":"Failed to release manual overide"}
image

Browsing to the url http://192.168.1.8/override shows:
{"msg":"No manual override"}

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

as you can see in your Monitoring screenshot there's no "state" property set by "manual" so no manual override. Everything is allright.
API reports an error if you delete a non existing claim or an override ( it is a claim too technically )

Are you sure you are not using the current dev build ? And you have set the /config/EVSE/ Default State to Active ?

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

Also if robot icon appears, it means you have either some timers set or selfprod | ocpp enabled. Shaper is working in the backgrnd of all charge tasks, it won't activate alone the evse, but it will disable it if there's not enough power left in the powerwall. It is not really part of an automation but a safety

@rvoosterhout
Copy link
Author

I'm not using the dev build at the moment. Where do I set the defaut state?

There is indeed no state propery set by manual in my monitoring, yet the display on my openevse unit shows manual override.

@rvoosterhout
Copy link
Author

I get it now. Disable the charger shows manual override on the display, Enabling the charger shows manual override on the display, Deleting manual override remove manual override on the display, but doesn't really do anything in the gui. It gives you the idea that manual override is still enabled. It would be better indeed if it shows something like 'Default' when the manual override is deleted.

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

Default state is only on current build, but forget my question, I forgot default state is actually to Active. You will be able to set that on next release ( or current dev build )

for you display problem, perhaps it's just a bug with lcd. I got some frozen line on some other situations, like in #597

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

You should forget the manual override term, with V2 gui there's no such thing. UX has changed. If you use any property in an /override , not only "state" one, I think it display manual_override on the lcd,
That's something we need to rework a bit.

it also always report "manual_override: 1" on /status & mqtt. This property has no much sense now ( and should probably be deleted ). The complete /override should be fetched at version change.

@rvoosterhout
Copy link
Author

I understand now, thank you for the explanation!

@KipK
Copy link
Collaborator

KipK commented May 22, 2023

you're welcome.
Talking about your use case makes me consider to always display the Auto ( robot ) button. It removes the state override, and will display the Default tag if there's nothing else so this makes sense now we have a configurable default state

@jeremypoulter
Copy link
Collaborator

It might make sense, the UI still has to interact with the override as the front panel button will do the same as the V1 UI, IE toggle override on/off so we either need to change that behaviour or handle it in the UI. IMHO it should be in 'auto' mode by default even if there aren't any special features setup

@KipK
Copy link
Collaborator

KipK commented May 23, 2023

yes, I have changed this in current master. I was not a fan of the Auto button popping in/out of nowhere. Looks more consistant now, and keep the logic everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants