Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a random start delay to the timer #391

Merged
merged 20 commits into from
Jul 20, 2022
Merged

Conversation

jeremypoulter
Copy link
Collaborator

Fix is a UK requirement to help prevent large loads being applied to the grid.

Fixes #350

The time is no longer used on the EVSE controler in a practical sense, only to reset the WiFi time after a reboot, as the EVSE may have an RTC, so this is much easier to do the the EVSE time is GMT
Added additional info into the schedule plan giving the current day/offset, current and next events and time to next event to aid in debugging.

Also API to notify of config changes.
This is to allow clients to know when the schedule or schedule plan has updated and fetch a fresh copy
This increases the reliability of connecting after a reboot
The current debug build is too big to be flashed with space left for OTA
so this partition table removed the OTA partition. Only for use in dev builds
A few bints of tidy up, temp enable of some debug, dev version of the ESP32 gateway board and enable the power cycling of the ethernet chip
@jeremypoulter jeremypoulter marked this pull request as draft July 18, 2022 23:44
@glynhudson
Copy link
Collaborator

Nice work! I've just had a quick test, and it seems to work great.

The only issue I've noticed is the 'next event' time requires a page refresh to update after the delay timer is updated. Would it be possible to update the 'next event' time without a page refresh?

I think the Current Event / Next Event text should only be shown when advanced display is togged on.

Is it possible to switch off the random delay?

What is the procedure for setting a default schedule before units are shipped?

@jeremypoulter
Copy link
Collaborator Author

The only issue I've noticed is the 'next event' time requires a page refresh to update after the delay timer is updated. Would it be possible to update the 'next event' time without a page refresh?

Will take a look

I think the Current Event / Next Event text should only be shown when advanced display is togged on.

Can make that change

Is it possible to switch off the random delay?

In advanced mode you can change the max time, just set to 0

What is the procedure for setting a default schedule before units are shipped?

TBD, still looking at that, worst case you can use the HTTP API to set: https://github.com/OpenEVSE/ESP32_WiFi_V4.x/blob/master/test/schedule.http#L89-L121

@glynhudson
Copy link
Collaborator

The only issue I've noticed is the 'next event' time requires a page refresh to update after the delay timer is updated. Would it be possible to update the 'next event' time without a page refresh?

This is now fixed 👍

I think the Current Event / Next Event text should only be shown when advanced display is togged on.

Confirmed fixed 👍

In advanced mode you can change the max time, just set to 0

Got it, I'll add a note to say this.

TBD, still looking at that, worst case you can use the HTTP API to set

Sure, that would work. Or we could just set it manually, it would only take a few seconds.

I think this is ready to merge?

@jeremypoulter jeremypoulter marked this pull request as ready for review July 20, 2022 11:37
@jeremypoulter jeremypoulter merged commit 752553c into master Jul 20, 2022
@jeremypoulter jeremypoulter deleted the jeremypoulter/issue350 branch July 20, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default time schedule and random delay UK legislation
2 participants