-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing landscape classifications for SLE project #1991
base: dev
Are you sure you want to change the base?
Conversation
I looked at what you did for a review - then I realized this should probably be a draft (instead of ready for review) since you still need to add changelog and term tracker. |
The following changes were implemented, as discussed with @stap-m on Monday:
I also added the |
Annotations: | ||
OEO_00020426 "issue: https://github.com/OpenEnergyPlatform/ontology/issues/1962 | ||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1991", | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "A protected area role is a role of a region of relevance recognised, dedicated and managed, through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values."@en, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<http://purl.obolibrary.org/obo/IAO_0000115> "A protected area role is a role of a region of relevance recognised, dedicated and managed, through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values."@en, | |
<http://purl.obolibrary.org/obo/IAO_0000115> "A protected area role is a role of a region of relevance recognised, dedicated and managed through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values."@en, |
I am not sure but I believe this comma should not be here.
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1592 | ||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1652 | ||
|
||
made class a 'region of relevance' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the protected area:
Rather than made class a 'region of relevance' I would prefer the info that this has moved here from oeo-physical. What do you think, @stap-m ?
(this is about lines 3405, 3406, 3207)
Summary of the discussion
For the SLE project, OEO concepts for multiple landscape classifications are needed, as described in #1962.
Type of change (CHANGELOG.md)
Add
legislation
as subclass ofplan specification
+'has part' some 'target description'
A legislation is a plan specification that is produced by a government and enables, prohibits or bans activities, or establishes rights or responsibilities.
ROG
as an instance oflegislation
The ROG is a legislation providing the legal framework for spatial planning in Germany.
BNatSchG
as an instance oflegislation
The BNatSchG is a legislation providing the legal framework for nature conservation and landscape management in Germany.
protected area role
as subclass ofrole
A protected area role is a role of a region of relevance recognised, dedicated and managed, through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values.
Fauna Flora Habitat role
as an instance ofprotected area role
A Fauna Flora Habitat role is a protected area role for areas, aimed at conserving natural habitats and wild fauna and flora, within the European "Natura 2000" network of protected areas.
'is defined by' BNatSchG
Bird Sanctuary role
as an instance ofprotected area role
A Bird Sanctuary role is a protected area role for areas, aimed at protecting and conserving endangered and migratory bird species, within the European "Natura 2000" network of protected areas.
'is defined by' BNatSchG
Fauna Flora Habitat
as an instance ofprotected area
A Fauna Flora Habitat is a protected area that has the Fauna Flora Habitat role.
'has role' 'Fauna Flora Habitat role'
Bird Sanctuary
as an instance ofprotected area
A Bird Sanctuary is a protected area that has the Bird Sanctuary role.
'has role' 'Bird Sanctuary role'
Update
protected area
oeo-physical
tooeo-model
two-dimensional spatial region
to being one ofregion of relevance
'has role' some 'protected area role'
A protected area is a region of relevance that has the protected area role.
conditionally reserved region
,priority region
,priority region with effect of suitable region
,suitable region
to instances ofregion of relevance
instead of being subclasses of itconditionally reserved region role
,priority region role
,suitable region role
role
instead of being subclasses of it'is defined by' ROG
Remove
---
Workflow checklist
Automation
Closes #1962
PR-Assignee
term tracker annotation
Reviewer