Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing landscape classifications for SLE project #1991

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

ColinHDev
Copy link
Contributor

@ColinHDev ColinHDev commented Dec 7, 2024

Summary of the discussion

For the SLE project, OEO concepts for multiple landscape classifications are needed, as described in #1962.

Type of change (CHANGELOG.md)

Add

  • Added legislation as subclass of plan specification + 'has part' some 'target description'
    • A legislation is a plan specification that is produced by a government and enables, prohibits or bans activities, or establishes rights or responsibilities.
  • Added ROG as an instance of legislation
    • The ROG is a legislation providing the legal framework for spatial planning in Germany.
  • Added BNatSchG as an instance of legislation
    • The BNatSchG is a legislation providing the legal framework for nature conservation and landscape management in Germany.
  • Added protected area role as subclass of role
    • A protected area role is a role of a region of relevance recognised, dedicated and managed, through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values.
  • Added Fauna Flora Habitat role as an instance of protected area role
    • A Fauna Flora Habitat role is a protected area role for areas, aimed at conserving natural habitats and wild fauna and flora, within the European "Natura 2000" network of protected areas.
    • Added an object property assertion: 'is defined by' BNatSchG
  • Added Bird Sanctuary role as an instance of protected area role
    • A Bird Sanctuary role is a protected area role for areas, aimed at protecting and conserving endangered and migratory bird species, within the European "Natura 2000" network of protected areas.
    • Added an object property assertion: 'is defined by' BNatSchG
  • Added Fauna Flora Habitat as an instance of protected area
    • A Fauna Flora Habitat is a protected area that has the Fauna Flora Habitat role.
    • Added an object property assertion: 'has role' 'Fauna Flora Habitat role'
  • Added Bird Sanctuary as an instance of protected area
    • A Bird Sanctuary is a protected area that has the Bird Sanctuary role.
    • Added an object property assertion: 'has role' 'Bird Sanctuary role'

Update

  • protected area
    • Moved from oeo-physical to oeo-model
    • Changed it from being a subclass of two-dimensional spatial region to being one of region of relevance
    • Added a subclass axiom: 'has role' some 'protected area role'
    • Updated its definition: A protected area is a region of relevance that has the protected area role.
  • Made conditionally reserved region, priority region, priority region with effect of suitable region, suitable region to instances of region of relevance instead of being subclasses of it
  • conditionally reserved region role, priority region role, suitable region role
    • Made to instances of role instead of being subclasses of it
    • Added an object property assertion: 'is defined by' ROG

Remove

---

Workflow checklist

Automation

Closes #1962

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module labels Dec 7, 2024
@madbkr
Copy link
Contributor

madbkr commented Dec 12, 2024

I looked at what you did for a review - then I realized this should probably be a draft (instead of ready for review) since you still need to add changelog and term tracker.
Except that everything look fine!

@ColinHDev ColinHDev requested review from stap-m and madbkr December 13, 2024 18:00
@ColinHDev
Copy link
Contributor Author

The following changes were implemented, as discussed with @stap-m on Monday:

  • Split Natura 2000 role into Bird Sanctuary role and Fauna Flora Habitat role
  • Removed spatial legislation

I also added the term tracker annotation and the changelog.

Annotations:
OEO_00020426 "issue: https://github.com/OpenEnergyPlatform/ontology/issues/1962
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1991",
<http://purl.obolibrary.org/obo/IAO_0000115> "A protected area role is a role of a region of relevance recognised, dedicated and managed, through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values."@en,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<http://purl.obolibrary.org/obo/IAO_0000115> "A protected area role is a role of a region of relevance recognised, dedicated and managed, through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values."@en,
<http://purl.obolibrary.org/obo/IAO_0000115> "A protected area role is a role of a region of relevance recognised, dedicated and managed through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values."@en,

I am not sure but I believe this comma should not be here.

issue: https://github.com/OpenEnergyPlatform/ontology/issues/1592
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1652

made class a 'region of relevance'
Copy link
Contributor

@madbkr madbkr Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the protected area:
Rather than made class a 'region of relevance' I would prefer the info that this has moved here from oeo-physical. What do you think, @stap-m ?
(this is about lines 3405, 3406, 3207)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

Missing landscape classifications for SLE project
2 participants