The definition of the turbine subclasses do not fit to the definition of turbine.

[l-emele]

Description of the issue

We defined Turbine:
A turbine is an energy converting device that converts energy from a moving fluid flow into rotational energy.

But the WindTurbine is currently defined as:
A wind turbine is a device that converts the wind's kinetic energy into electrical energy.

This definition of WindTurbine currently describes more, what a WindEnergyConvertingUnit.

Current definition of GasTurbine:
A gas turbine, also called a combustion turbine, is a type of continuous combustion, internal combustion engine.

HydrogenTurbine:
A hydrogen turbine is a turbine fueled with liquid hydrogen.

SteamTurbine:
A steam turbine is a device that extracts thermal energy from pressurized steam and uses it to do mechanical work on a rotating output shaft.

WaterTurbine:
A water turbine is a rotary machine that converts kinetic energy and potential energy of water into mechanical work.

Ideas of solution

Update all subclass definition. Example for a new WindTurbine definition:
A wind turbine is a device that converts the wind's kinetic energy into rotational energy.

Workflow checklist

• I discussed the issue with someone else than me before working on a solution
• I already read the latest version of the workflow for this repository
• I added this issue to the Project 'Issues'. If suitable, I add it to further Projects.
• The goal of this ontology is clear to me

I am aware that

• every entry in the ontology should have an annotation
• classes should arise from concepts rather than from words
• class or property names should follow the UpperCamelCase

[stap-m]

Absolutely. The new def sounds good.
We could also think about renaming the class to e.g. wind rotor to avoid confusion with the very ambigous term wind tubine.

[stap-m]

The defs of the other turbine subclasses could be refined aswell...

[l-emele]

The defs of the other turbine subclasses could be refined aswell...

You are right, I adapted the issue that it covers all.

[l-emele]

Proposals:

• GasTurbine: A gas turbine is a turbine that converts chemical energy into rotational energy using a continous internal combustion process. Hence it is also called combustion turbine.
• HydrogenTurbine: A hydrogen turbine is a gas turbine fueled with hydrogen.
• SteamTurbine: A steam turbine is a turbine that converts heat from pressurized steam into rotational energy.
• WaterTurbine: A water turbine is a turbine converting kinetic energy and potential energy of water into rotational energy.
• WindRotor: A wind rotor (or wind turbine) is a turbine that converts the wind's kinetic energy into rotational energy.

In theory we do not need the part into rotational energy for all of the turbine subclasses as already the parent class has it. But for clarity I would include it in all these subclass definitions.

We could also think about renaming the class to e.g. wind rotor to avoid confusion with the very ambigous term wind tubine.

Your idea is actually very good. If we use WindRotor as primary label we could use WindTurbine as secondary label for both WindRotor and WindEnergyConverter. This then shows that the term WindTurbine is ambiguous.