Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMP not actually required? #2117

Closed
marchdf opened this issue Mar 26, 2024 · 3 comments · Fixed by #2121
Closed

OpenMP not actually required? #2117

marchdf opened this issue Mar 26, 2024 · 3 comments · Fixed by #2121
Assignees
Milestone

Comments

@marchdf
Copy link
Contributor

marchdf commented Mar 26, 2024

Bug description
If building for C++ (BUILD_OPENFAST_CPP_API), then FIND_PACKAGE requires that it finds OpenMP (https://github.com/OpenFAST/openfast/blob/main/CMakeLists.txt#L114). That will fail if openmp is not found but strictly speaking openmp should not be required when building the API. Further checks, check that it actually found OpenMP but the REQUIRED keyword does not actually let the code get to them.

To Reproduce
Build the CPP API on machine that does not have openmp and with the default option(OPENMP "Enable OpenMP support" off).

Expected behavior
Described above

Screenshots, if applicable
NA
OpenFAST Version
3.5.2

System Information (please complete the following information):

  • OS: OSX
  • Compiler: GCC 13
@andrew-platt andrew-platt added this to the v3.5.3 milestone Mar 26, 2024
@andrew-platt andrew-platt self-assigned this Mar 26, 2024
@andrew-platt
Copy link
Collaborator

Thanks for letting us know! I'll take a look at this.

@andrew-platt
Copy link
Collaborator

See #2120 for proposed fix.

@andrew-platt
Copy link
Collaborator

Fixed with #2120. This will be included in v3.5.3 later this week.

@andrew-platt andrew-platt linked a pull request Mar 26, 2024 that will close this issue
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants