Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 4: Clean up other APIs #892

Open
aleksa-krolls opened this issue Jan 9, 2025 · 3 comments
Open

Phase 4: Clean up other APIs #892

aleksa-krolls opened this issue Jan 9, 2025 · 3 comments
Assignees

Comments

@aleksa-krolls
Copy link
Member

aleksa-krolls commented Jan 9, 2025

See parent issue #887 for details.

@martalovescoffee
Copy link

@hunterachieng could you please add an estimate to this issue?

@josephjclark
Copy link
Collaborator

This will be a breaking release, so we should take a breath and make any other breaks we want.

For example, we should remove callbacks here (the API is inconsistent right now)

@josephjclark
Copy link
Collaborator

Consider phase 6: any changes we want to make for the sake of documentation, we need to do here.

i suggest:

  1. we remove the other APIs
  2. before we release, review what's left and tweak signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

4 participants