Skip to content

Commit

Permalink
Handle the modal_close event in WorkflowLive.edit (#2649)
Browse files Browse the repository at this point in the history
* close #2622


---------

Co-authored-by: Stuart Corbishley <corbish@gmail.com>
  • Loading branch information
taylordowns2000 and stuartc authored Nov 10, 2024
1 parent 997f76c commit 2f3ba75
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ and this project adheres to

### Fixed

- Fix LiveView crash when pressing "esc" on inspector
[#2622](https://github.com/OpenFn/lightning/issues/2622)

## [v2.10.0-rc.1] - 2024-11-08

### Changed
Expand Down
5 changes: 5 additions & 0 deletions lib/lightning_web/live/workflow_live/edit.ex
Original file line number Diff line number Diff line change
Expand Up @@ -1661,6 +1661,11 @@ defmodule LightningWeb.WorkflowLive.Edit do
end
end

def handle_event(_unhandled_event, _params, socket) do
# TODO: add a warning and/or log for unhandled events
{:noreply, socket}
end

@impl true
def handle_info(
%WorkflowUpdated{workflow: updated_workflow},
Expand Down

0 comments on commit 2f3ba75

Please sign in to comment.