Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Export only including one Marker #32

Closed
morehawes opened this issue Jan 22, 2024 · 1 comment
Closed

Bug: Export only including one Marker #32

morehawes opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed To-Do

Comments

@morehawes
Copy link
Collaborator

I'm not sure why, but I am only getting one Marker when using the Export feature on the front end 😕

I have been able to replicate locally and on waymark.dev.

This does not appear to be a file format issue - is occurring on GPX/KML/GeoJSON.

No idea when this was introduced. Will need to look in to the export logic when I get more time.

@morehawes morehawes added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers To-Do labels Jan 22, 2024
@morehawes morehawes self-assigned this Jan 22, 2024
@morehawes
Copy link
Collaborator Author

Fixed in this commit and will be included in the next release.

It turned out that the logic to determine if the Overlay is currently "visible" on the Map (if enabled, the Overlay Filter can hide Overlays by Type) was no longer working and there didn't seem to be an obvious solution.

I decided to remove the ability for the Overlay Filter to determine which Overlays Export and to just export all Overlays. The Export feature needs work, probably an overhaul so this de-coupling is going to make that easier and I can't think of anyone mentioning this feature.

If it is missed by anyone, perhaps it can be re-implemented in Export v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed To-Do
Development

No branches or pull requests

1 participant