Add screenshot provenance to notebooks #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
add-screenshots-for-html-export
branch
from
8dffaf3 to
e2f2855
Compare
|
@danlamanna are we expecting more code to be pushed onto this branch? Or is this ready for review. Perhaps you have to update it with master? |
|
@aashish24 More code will be pushed to this branch |
danlamanna
changed the title
ok thanks. |
danlamanna
force-pushed
the
add-screenshots-for-html-export
branch
2 times, most recently
from
bfd6491 to
be197d1
Compare
danlamanna
changed the title
|
This has now been drastically scaled back due to issues with the asynchronous nature of the notebook. There's now a button to take screenshots which will be displayed (only when on a code cell) and endure exports to various formats. @kotfic |
danlamanna
force-pushed
the
add-screenshots-for-html-export
branch
from
be197d1 to
a6c631d
Compare
kotfic
approved these changes
Mar 13, 2017
Due to various issues with how the notebook fundamentally works (asynchronously). It was decided that it would be better for now to allow the screenshotting of the map to be a manual process. This commit adds a button which does just that.
danlamanna
force-pushed
the
add-screenshots-for-html-export
branch
from
a6c631d to
a7e8d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if provenance is really the right word for it, but here it is.
Right now it's using a base64 image of a cat, but the logic is the same and will be replaced with a call to
Map.screenshotwhen OpenGeoscience/geojs#665 is merged.This essentially adds a screenshot of the map (hidden to the user) to the Jupyter notebook output each time a python cell is executed. The screenshot is stored in the
.ipynbfile which means that when an export to other formats (such as static HTML) is performed, the user can see step by step what happened to the GeoJS map as python commands were executed.The only really hacky part about this (besides using
_.wrap) is that we have to hide all PNG output by default with css to avoid our screenshot PNGs flashing on the screen for a second when the user loads the notebook. This means we have to "unhide" the other PNGs when they're rendered (and on load).Integration test forthcoming.