Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nogil for most types of methods #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpfeuffer
Copy link
Contributor

This requires a change in conversion providers.
+Some other cleanups.

This requires a change in conversion providers.
+Some other cleanups.
@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Nov 18, 2023

I will fix tests because of newer typing syntax

Copy link
Contributor

@poshul poshul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Any idea what sort of performance improvements we are likely to see?

@jpfeuffer
Copy link
Contributor Author

Probably none out of the box.
But it allows to use our functions in a multi threaded python context e.g. via the python threading module.

This brings some responsibilities for the user with it but you can decide which functions are safe to use.

Copy link
Contributor

@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super confident that I understand all parts. Would be great if in general methods would contain a brief comment e.g.the new _split one etc.

@jpfeuffer
Copy link
Contributor Author

This is a breaking change. Be prepared to fix OpenMS if you merge this.

@poshul
Copy link
Contributor

poshul commented Apr 16, 2024

Given that we already need to do some fixes for OpenMS to get it to work with the current develop version of autowrap, I'm good merging this in and planning to have the core group sit down and fix at some point in the future.

@timosachsenberg
Copy link
Contributor

what needs to be done to work with the current develop version of autowrap otherwise?

@timosachsenberg
Copy link
Contributor

and what would need to be fixed?

@poshul
Copy link
Contributor

poshul commented Apr 16, 2024

and what would need to be fixed?

#186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants