Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates columns in Backend grids need visual improvement #2198

Closed
addison74 opened this issue Jun 6, 2022 · 2 comments · Fixed by #2267
Closed

Dates columns in Backend grids need visual improvement #2198

addison74 opened this issue Jun 6, 2022 · 2 comments · Fixed by #2267
Assignees

Comments

@addison74
Copy link
Contributor

addison74 commented Jun 6, 2022

In Backend grids have columns where you can filter the data by date.

This is how the columns in the "Catalog Price Rules" section look like now (OpenMage 20.14):

before

This is how the columns would look like based on my future change:

after

What are the benefits?

  • Those colons used after words To, From and In don't look good at all.

  • The icon for calendar popup is placed immediately after the text when in fact it should be placed after the input box.

  • The input boxes are a little bit increased. As you can see the date you fill in does not appear completely andit is truncated due to the width limitation set to 50px. In my proposal I changed it to 60px to cover all situations.

This is a visual enhancement. Any opinions are welcome.

@elidrissidev
Copy link
Member

I agree with this change, it's more natural to have the date selection button to the right of the input.

@addison74
Copy link
Contributor Author

I will take care of this issue. Two PR's will be ready to fix visual issues in filter columns separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants