Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

without the tool in admin panel #926

Closed
loopCM opened this issue Apr 13, 2020 · 13 comments
Closed

without the tool in admin panel #926

loopCM opened this issue Apr 13, 2020 · 13 comments
Labels
Component: Backup Relates to Mage_Backup invalid

Comments

@loopCM
Copy link

loopCM commented Apr 13, 2020

when I install the magento-lts, The configure->tool can not use

@tmotyl
Copy link
Contributor

tmotyl commented Apr 13, 2020

I dont understand this issue. Please describe it better (steps, screenshot) otherwise it will be closed.

@loopCM
Copy link
Author

loopCM commented Apr 13, 2020

image
There are no backup and Compilation options here

@Flyingmana
Copy link
Contributor

yes, we removed the compile option, because the benefit was very little but caused a lot of problems.

We removed the backup option, as we assumed only very few people using it. This may have been a wrong assumption. Most people we know backup the database via database specific tools, as they are a lot more flexible and performant then doing it via Magento.

We still need to add documentation for this.

@loopCM
Copy link
Author

loopCM commented Apr 14, 2020

Yes, thank you very much for your reply, I hope to have a backup function, a document is better.

@loopCM
Copy link
Author

loopCM commented Apr 14, 2020

I think a big part of people is to use it, I think leaving these functions than the convenience brought by the delete it will be better, maybe you can set a the enable/disable function, so it will be more convenient, because I think you the original idea is to develop this branch magento1 can more people are going to continue to use, thank you very much for your hard work

@colinmollenhour
Copy link
Member

The backup feature is half-baked. To restore from it you would have to know how to do that anyway so it gives users who don't know how to create a backup a false sense of security.

If you really want it, you can restore this removed code from the magento mirror repo, but I don't think anyone in this project is interested in supporting this code and I think it is better that it is removed than to leave it in place as it poses a security risk and a stability risk (e.g. filling up your disk with backups) and if we aren't really supporting it then it should be removed so people are not under the false impression that the tool is supported.

Looks like we do need to remove the "Tools" menu from the XML though as this is empty now..

@simbus82
Copy link
Contributor

yes, we removed the compile option, because the benefit was very little but caused a lot of problems.

We removed the backup option, as we assumed only very few people using it. This may have been a wrong assumption. Most people we know backup the database via database specific tools, as they are a lot more flexible and performant then doing it via Magento.

We still need to add documentation for this.

We have ~10 magento and our people are instructed to do a backup for every "critical" change (even before promotion for example).
In a transition like this you can't remove elements by assumption without data.

@colinmollenhour
Copy link
Member

Perhaps it can be resurrected as a module in a separate repo that can easily be included using Composer?

@loopCM
Copy link
Author

loopCM commented Apr 28, 2020

yes, we removed the compile option, because the benefit was very little but caused a lot of problems.
We removed the backup option, as we assumed only very few people using it. This may have been a wrong assumption. Most people we know backup the database via database specific tools, as they are a lot more flexible and performant then doing it via Magento.
We still need to add documentation for this.

We have ~10 magento and our people are instructed to do a backup for every "critical" change (even before promotion for example).
In a transition like this you can't remove elements by assumption without data.

This is what I want to talk about, because this is useful when you have multiple magento's

@colinmollenhour
Copy link
Member

Well it appears this was actually disabled in core and not by OpenMage..
https://github.com/OpenMage/magento-mirror/blob/magento-1.9/app/etc/modules/Mage_All.xml#L237

So it turns out we just disabled unknowingly (to me at least) when this update was merged..

@simbus82, as to your point about the data, it seems the data shows that since Nov 28, 2018 only two users have cared that Mage_Backup was disabled.

If you want to use it, (I still advise not to but at your own risk you can do whatever you want), just enable it again by adding an xml file to app/etc/modules:

<config>
    <modules>
        <Mage_Backup>
            <active>true</active>
        </Mage_Backup>
    </modules>
</config>

@kiatng
Copy link
Contributor

kiatng commented Apr 29, 2020

Backup was disabled officially in 1.9.4.0, documented here:

Note that after updating to this release, third-party modules that depend upon Magento core backup functionality will no longer work. Alternatively, you can use one of these two methods to enable database backups:

Change false to true in the config > modules > Mage_Backup > active setting of app/etc/modules/Mage_All.xml.
From the Admin, change the System > Configuration > Advanced > Disable Modules Output > Mage_Backup from disabled to enabled.

@simbus82
Copy link
Contributor

simbus82 commented May 21, 2020

Thank you for all clarification!
I tell this to my team (and customers) to start use a more robust "instant" backup/snapshot method.

@sreichel sreichel added invalid Component: Backup Relates to Mage_Backup labels Jun 6, 2020
@addison74
Copy link
Contributor

Starting with version 1.9.4.0 Mage_Backup module is deactivated/disabled as mentioned before by @kiatng, but Tools link still appears in the System menu.

A small change into the code code is needed to avoid seeing an empty link (see my report here #1368). My suggestion is to keep Tools link hidden if the Mage_Backup is deactivated/disabled. Once someone wants to activate the module and its output this link should appear as expected in Tools submenu.

The other link in Tools submenu called Compilation was a necessity to be removed from Magento as PHP 7 has its own opcache or we use Varnish to improve the performance.

To maintain a back compatibility for those who will migrate to OpenMage my suggestion is not removing this module from code core just leaving it in place. Even I prefer my own backups with cronjobs some 3rd party modules could depend on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backup Relates to Mage_Backup invalid
Projects
None yet
Development

No branches or pull requests

8 participants