Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected test behavior #46

Closed
treywelsh opened this issue Jun 26, 2020 · 1 comment
Closed

Fix unexpected test behavior #46

treywelsh opened this issue Jun 26, 2020 · 1 comment

Comments

@treywelsh
Copy link
Collaborator

Some PRs add/remove the ExpectNonEmptyPlan flags to the tests, sometimes to make it pass.
We probably miss something, this should be investigated.

Some terraform doc for reference

To illustrate, here are some PR, that switch these tags at the same place in template and virtual machine tests:
@treywelsh
Copy link
Collaborator Author

treywelsh commented Jul 3, 2020 •
edited
Loading

The changes on ExpectNonEmptyPlan that made me open this issue were finally reverted as part of #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@treywelsh