Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix ip6 support #587

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Thiryn
Copy link
Contributor

@Thiryn Thiryn commented Jan 23, 2025

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Fixes #586. Introduces the following changes:

  • Ensure AR fields are parsed correctly when reading VNet structures (using the correct XML names)
  • Fix the bad ula_prefix in AR
  • Add the capability to create VR NIC with static IPv6
  • Add reservation_first_ip6 to opennebula_virtual_network to allow to create Network reservations on IP6.
  • Fix the handlng of IPv6 for Vrouter NICs with floating IP6

Also add another fix which is not mentioned in the Issue but can not be introduced separately as its side effect makes tests fail:

  • Allow AR deletion to be retried on when the error is Address Range has leases in use. This can happen for example when a NIC is deleted and the AR deleted immediatly after. The NIC may be deleted in the ON API but the associated IP lease may take a further few seconds to actually be removed from the AR.

New or Affected Resource(s)

  • opennebula_virtual_network_address_range
  • opennebula_virtual_router_nic
  • opennebula_virtual_network

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPV6 support is incomplete and buggy in VRouter NIC and AddressRange
1 participant