Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment of programming document in cups web interface #344

Closed
chandresh-soni opened this issue Mar 2, 2022 · 8 comments
Closed

Misalignment of programming document in cups web interface #344

chandresh-soni opened this issue Mar 2, 2022 · 8 comments
Labels
bug Something isn't working investigating Investigating the issue

Comments

@chandresh-soni
Copy link

The programming manual portion of cups in the web interface has some misalignment, making certain pages difficult to read.

Screenshot from 2022-03-02 17-51-30
Screenshot from 2022-03-02 17-51-33
Screenshot from 2022-03-02 17-51-41
Screenshot from 2022-03-02 17-51-47
Screenshot from 2022-03-02 17-51-52
Screenshot from 2022-03-02 17-51-58

These help documents are also available on the openprinting website, where they function properly; however, in the cups web interface, the header clashes with the header of the html file, resulting in the overflow.

I can open a PR to resolve this issue in some time.

@zdohnal
Copy link
Member

zdohnal commented Mar 2, 2022

Hi @Chandresh2702 ,

thank you for reporting the issue!

Unfortunately, I don't see any issue which you've captured by your screenshots (Fedora 35, cups-2.3.3op2, Firefox 97.0.1-2.fc35). What CUPS version do you have and what Firefox version do you use?

Maybe even cookies or browser plugins/script can IMHO influence this, so it would be great if you tried it in clean Firefox without plugins and cookies.

@zdohnal zdohnal added investigating Investigating the issue unable-to-reproduce Unable to reproduce waiting for reporter There are data requested from the reporter labels Mar 2, 2022
@chandresh-soni
Copy link
Author

i am using current git code as i was working on some other issue i refereed to these , and i am using Ubuntu 20.04 and firefox 97.0 and i am getting same issue on chromium Version 98.0.4758.102 (Official Build) snap (64-bit) on my laptop. i will try it with clean browser as you have told and will let you know

@chandresh-soni
Copy link
Author

@zdohnal i tried after cleaning all data of my firefox but problem is still there.

@jsmeix
Copy link

jsmeix commented Mar 2, 2022

I also experience since some longer time that the actual content
is placed where some kind of header and footer is (example below)
or even that some header and footer is placed over the actual content
(right now I found no example for the latter).

E.g. currently on my openSUSE Leap 15.3 system with Firefox
https://openprinting.github.io/cups/doc/man-cancel.html
shows as last readable line in the content area
(left aligned on white background)

Copyright © 2021 by OpenPrinting. 

while the actually two more lines of content

                Copyright © 2020-2021 OpenPrinting.    CUPS License

are shown in some kind of footer area
(centered on gray background)
where it is not visible that "CUPS License" is a link
(except one hovers the mouse pointer over it).

For comparison
w3m -dump https://openprinting.github.io/cups/doc/man-cancel.html | less
shows as last lines

Copyright © 2021 by OpenPrinting.
Copyright © 2020-2021 OpenPrinting.

  • CUPS License

@chandresh-soni
Copy link
Author

@zdohnal I think this issue is created after the release of 2.3.3op2 as i inspected those files which are affected and they had gone under some changes after that could you please try one creating this issue with newer version of cups.

@zdohnal
Copy link
Member

zdohnal commented Mar 2, 2022

@Chandresh2702 thank you, you're absolutely right! I'm able to reproduce the issue with the latest 2.4.1. I'll look into it tomorrow, if you're able, PRs are always welcome! :)

@jsmeix thanks for the tips! To be honest, I'm not quite sure how CUPS pages on the OpenPrinting site are generated... I'll ask Mike in the future.

@zdohnal zdohnal added bug Something isn't working and removed unable-to-reproduce Unable to reproduce waiting for reporter There are data requested from the reporter labels Mar 2, 2022
@chandresh-soni
Copy link
Author

@zdohnal I have opened a PR addressing this issue could you review it once. thanks you :)

here are some of screenshots after code change.
Screenshot from 2022-03-02 18-14-16
Screenshot from 2022-03-02 18-14-19
Screenshot from 2022-03-02 18-14-25
Screenshot from 2022-03-02 18-14-28
Screenshot from 2022-03-02 18-14-30
Screenshot from 2022-03-02 18-14-35
Screenshot from 2022-03-02 18-14-37

Please let me know if there is anything further that needs to be done in this regard.

@zdohnal
Copy link
Member

zdohnal commented Mar 8, 2022

Fixed by 77bcfb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigating Investigating the issue
Projects
None yet
Development

No branches or pull requests

3 participants