Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change profile routes to be internal #765

Closed
peb-adr opened this issue Aug 31, 2023 · 3 comments · Fixed by #770
Closed

Change profile routes to be internal #765

peb-adr opened this issue Aug 31, 2023 · 3 comments · Fixed by #770
Assignees
Labels
enhancement General enhancement which is neither bug nor feature
Milestone

Comments

@peb-adr
Copy link
Member

peb-adr commented Aug 31, 2023

We want to gather some profile data. But the fact it is atm publicly served when enabled is concerning.

Please change the routes to be internal such that it will not get routed by the proxy.
We will then get the profiles by curling them from inside the stack or something similar.

@ostcar
Copy link
Member

ostcar commented Aug 31, 2023

I can do this.

In this case, there is no need to activate the profiling routes via an environment varialbe. All the variable does is adding the route. The profiling code is in the go runtime anyway.

Is this ok for you?

@peb-adr
Copy link
Member Author

peb-adr commented Aug 31, 2023

Well yeah I guess it would be okay then..
@rrenkert speak up if you're against this ;)

@rrenkert
Copy link
Contributor

Already talked to @ostcar. That's ok for me!

@jsangmeister jsangmeister added the enhancement General enhancement which is neither bug nor feature label Sep 5, 2023
@jsangmeister jsangmeister added this to the 4.1 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants