Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum to import_preview/name #1920

Closed
jsangmeister opened this issue Sep 30, 2023 · 2 comments · Fixed by #2050
Closed

Add enum to import_preview/name #1920

jsangmeister opened this issue Sep 30, 2023 · 2 comments · Fixed by #2050
Assignees
Labels
Milestone

Comments

@jsangmeister
Copy link
Contributor

As suggested in OpenSlides/openslides-autoupdate-service#781, we should constrain the values of this field with an enum to ensure only valid import names are entered. Also, I think that type would be more fitting as a field name.

@r-peschke
Copy link
Member

The backend json-uploads and imports are each individual actions and each one uses and tests the name field-content individually. Therefore an enum doesn't help. It just let us extend the enum for each new import.
The fieldname name was choosen with the idea to differentiate the imports. I would suggest to improve the name-field content by a more specific name, i.e. "import motions for summer-event ...".
Written this, I see 2 fields, name and type. But do we need this now?

@jsangmeister
Copy link
Contributor Author

As discusssed: We will add an enum for the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants