Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent group rights "user.can_manage" if a user in this group is locked out #2598

Closed
Elblinator opened this issue Sep 9, 2024 · 2 comments · Fixed by #2616
Closed

Prevent group rights "user.can_manage" if a user in this group is locked out #2598

Elblinator opened this issue Sep 9, 2024 · 2 comments · Fixed by #2616
Assignees
Milestone

Comments

@Elblinator
Copy link
Member

Elblinator commented Sep 9, 2024

Current behaviour:
You can give a participant manage rights even though they are locked out

Reproduction:

  • Put a participant in a group "blob"
  • lock this participant out
  • now give the group "blob" the permissions to manage users

Wanted behaviour:
If a user is locked out then their group(s) are not allowed to get the permission user.can_manage

@Elblinator Elblinator added this to the 4.2 milestone Sep 9, 2024
@Elblinator Elblinator changed the title Prevent group rights "user.canUpdate" if a user in this group is lockedout Prevent group rights "user.can_update" if a user in this group is lockedout Sep 9, 2024
@Elblinator Elblinator added the high label Sep 9, 2024
@bastianjoel
Copy link
Member

We could also just always allow unlocking out a user from a meeting.

That way it would not be a problem if a group gets those rights while a locked out user is in it because the user can still be unlocked.

@bastianjoel bastianjoel removed their assignment Sep 10, 2024
@Elblinator Elblinator changed the title Prevent group rights "user.can_update" if a user in this group is lockedout Prevent group rights "user.can_manage" if a user in this group is locked out Sep 10, 2024
@Elblinator
Copy link
Member Author

We decided against the concept of always allowing to unlock participants because it is possible to prematurely unlock a participant, who cannot be locked out again due to their group permissions even though they should be re locked out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants