Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing loading bar for a motion #2719

Closed
Elblinator opened this issue Aug 29, 2023 · 7 comments · Fixed by #4024
Closed

Fix missing loading bar for a motion #2719

Elblinator opened this issue Aug 29, 2023 · 7 comments · Fixed by #4024
Assignees
Labels
Milestone

Comments

@Elblinator
Copy link
Member

Current behaviour:
if you move via the arrows in between the motions then the loading bar does not appear but the words 'undefined'

Recreation:

  1. create at least two motions (I recommend long motion > 1000 words)
  2. go into motion 1
  3. reload page
  4. press the arrow in the top right region to navigate to the next motion
  5. no loading bar but undefined

Wanted behaviour:
The loading bar should also appear if you use the arrows to move in between motions

@reiterl
Copy link
Member

reiterl commented Oct 5, 2023

I cannot reproduce the problem on my developer setup. After clicking on the right-arrow the large motion instantly appears.

@jsangmeister
Copy link
Contributor

Maybe try killing the autoupdate service while you are on a motion detail view and then try to navigate via the arrow buttons.

@Elblinator
Copy link
Member Author

I tried it with more than 1000 motions (our biiiig dataset) and it still happens.

Apparently you need not only rather big motions but also a lot of them

@Elblinator Elblinator removed their assignment Oct 18, 2023
@Elblinator
Copy link
Member Author

I also tried it again with my own localhost
I have:

  • 21 motions, 9 of them are amendments
  • there are very long motions with +1000 words
  • but also 10 which have at most 5 words

I can provoke the "undefined" if I skip through the motions (via arrow) very fast. But I can also see the "undefined" when I leisurely move from one motion to the other (also for motions with one word).

I am not doing anything else besides pressing the arrow.

@Elblinator Elblinator modified the milestones: 4.1, 4.2 Dec 6, 2023
@reiterl
Copy link
Member

reiterl commented Feb 23, 2024

I can reproduce this problem. I have 10 motions. Reload, go into the detail view, press in the arrow-navigation on next/prev. See "undefined" for a moment.

@reiterl
Copy link
Member

reiterl commented Feb 23, 2024

Mmh, the component which seems to have this failure is: os-motion-detail-original-change-recommendations.
TextLoaded doesn't seem to work right and doesn't show the mat-progress-bar. and there is a wrong html set to this
component in the beginning. (Sth like: "...undefined"). So the "undefined" is shown. I think the motion-diff part is setting the html. Strange.

@bastianjoel
Copy link
Member

could be addressed in #4023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants