Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motions > Editor: empty paragraph line leads to wrong behavior in amendments #4181

Open
MSoeb opened this issue Sep 26, 2024 · 2 comments · May be fixed by #4343
Open

Motions > Editor: empty paragraph line leads to wrong behavior in amendments #4181

MSoeb opened this issue Sep 26, 2024 · 2 comments · May be fixed by #4343
Assignees
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Sep 26, 2024

Describe the bug
If a text in the editor contains an empty paragraph - set with Enter - this has an effect on amendments. Amendments that are placed on an 'empty' line are assigned line 0. In addition, the paragraph set in the editor is not visible in the motion. It is only visible in the editor or in the amendment creation screen.

Image of line 0 amendment:
image

How to Reproduce
Steps to reproduce the behavior:

  1. open a meeting
  2. open motions
  3. create a motion which includes a paragraph set by enter
  4. create an amendment to it and choose the empty line
  5. --> Amendment should have now line 0 as base.

Expected behavior
If a paragraph is set in the editor using Enter, then this paragraph should also be visible in the motion and have the correct line numbering. It should also be possible to create a change request in this line.

Additional context
In OpenSlides 3 this was solved in the editor with a no-break space ( &nbsp ).

Important: In the editor, however, it should still be possible to create a line break with SHIFT+ENTER that does not create a new line numbering. It is only about a line break with Enter.

@MSoeb MSoeb added this to the 4.2 milestone Sep 26, 2024
@bastianjoel
Copy link
Member

Could you please further specify what the "correct line numbering" should be?

@MSoeb
Copy link
Author

MSoeb commented Oct 14, 2024

Could you please further specify what the "correct line numbering" should be?

Note: All images from OS3.

Example image how a Text with an intented line done with ENTER should look like.
image

Editor view:
image

Editor code view:
image

In comparision a line done with SHIFT+ENTER. The gap is visible, but a new line numbering is not provided. Short: Enter = line numbering vs. SHIFT+Enter = no line numbering
image

@Elblinator Elblinator assigned Elblinator and unassigned Elblinator Nov 7, 2024
@bastianjoel bastianjoel self-assigned this Nov 12, 2024
@bastianjoel bastianjoel linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants