Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small domain inconsistencies in notCredible #23

Open
monkeyfish99 opened this issue Feb 2, 2017 · 3 comments
Open

Small domain inconsistencies in notCredible #23

monkeyfish99 opened this issue Feb 2, 2017 · 3 comments

Comments

@monkeyfish99
Copy link
Contributor

Using the .csv file for line numbers, these are inconsistent to the majority of the list:

  • Line 86, channel-7-news.com/ should be channel-7-news.com
  • Line 178, educateinspirechange.org/health should be educateinspirechange.org
  • Line 508, thegoldandoilguy.com/articles should be thegoldandoilguy.com
@monkeyfish99
Copy link
Contributor Author

Fixed in pull request #24, if accepted.

@uncompiled
Copy link
Contributor

IMO, it would be better if you separated #24 into two PRs. One for fixing domain inconsistencies and another for changing the format of the credible data. It looks like the BS Detector plugin relies on the existing data format, so there might be some reason for the inconsistency between the credible and notCredible formats.

@monkeyfish99
Copy link
Contributor Author

monkeyfish99 commented Feb 2, 2017

In my personal opinion, I think a fix of that would be valuable, if the plugin can be fixed, it would likely be easier to manage the plugin with a more consistent data format.
Although I'm yet to look at the plugin, so I have no idea how easy it would be to patch it, so I'm not sure.

Edit: Looking at the extension, at least the browser one, it uses the notCredible format, not the credible one.
Although I haven't looked at the native Chrome expansion, I'm only looking at https://github.com/bs-detector/bs-detector/blob/dev/browserscript/bs-detector.user.js#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants