Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth2 App database should not require the refresh_endpoint #59

Closed
forslund opened this issue Jan 14, 2024 · 3 comments
Closed

Oauth2 App database should not require the refresh_endpoint #59

forslund opened this issue Jan 14, 2024 · 3 comments
Assignees

Comments

@forslund
Copy link
Contributor

According to the specs for oauth2 the token endpoint shall be used for the refresh: https://www.oauth.com/oauth2-servers/making-authenticated-requests/refreshing-%20%20an-access-token/

I suggest we deprecate the argument in the OAuthApplicationDatabase, or can it be cut completely without breaking the entire world?

@JarbasAl
Copy link
Member

JarbasAl commented Jan 14, 2024

i'd say we cut it and bump a version number to signal the breaking change just in case, only the HA plugin, alerts skill and spotify use oauth, not too much out there for us to update

assigned the 3 relevant maintainers to this issue so everyone is in the loop

@mikejgray
Copy link
Contributor

@forslund @JarbasAl I just took a look at the HA plugin. I don't think it's event using this as it's delegating to the OAuth plugin entirely, so as long as that plugin can handle it we shouldn't have a problem.

@forslund
Copy link
Contributor Author

Closed via #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants