Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set bc #128

Merged
merged 4 commits into from
Nov 5, 2017
Merged

Set bc #128

merged 4 commits into from
Nov 5, 2017

Conversation

bemcdonnell
Copy link
Member

Closes #127

Wraps new API function In pyswmm/Stormwater-Management-Model#95

@bemcdonnell bemcdonnell self-assigned this Nov 3, 2017
@bemcdonnell bemcdonnell added this to the v0.4.4 milestone Nov 3, 2017
katmratliff
katmratliff approved these changes Nov 4, 2017
View reviewed changes
Copy link
Contributor

@katmratliff katmratliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@bemcdonnell bemcdonnell merged commit c1c5885 into pyswmm:dev-0.4.x Nov 5, 2017
@bemcdonnell bemcdonnell deleted the set_bc branch November 5, 2017 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katmratliff katmratliff katmratliff approved these changes

@abhiramm7 abhiramm7 abhiramm7 approved these changes

@goanpeca goanpeca Awaiting requested review from goanpeca

@aerispaha aerispaha Awaiting requested review from aerispaha

@michaeltryby michaeltryby Awaiting requested review from michaeltryby

Assignees

@bemcdonnell bemcdonnell

Labels
reso:completed type:enhancement
Projects
None yet
Milestone
v0.4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@bemcdonnell @katmratliff @abhiramm7