Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add maxRetry option for curtain #612

Closed
dnicolson opened this issue Dec 11, 2022 · 1 comment · Fixed by #631
Closed

Feature Request: Add maxRetry option for curtain #612

dnicolson opened this issue Dec 11, 2022 · 1 comment · Fixed by #631
Assignees
@Minsheng @donavanbecker @chenliuyun @SwitchBot @SwitchBot-Wonderlabs @Devin-Wonderlabs
Labels
enhancement New feature or request

Comments

@dnicolson
Copy link
Collaborator

Problem

The BLE connection often fails on the first attempt

Solution

Add maxRetry option

Alternatives

No response

Additional context

No response
@dnicolson dnicolson added the enhancement New feature or request label Dec 11, 2022
@dnicolson
Copy link
Collaborator Author

The maxRetry option is only included in the bot type:

homebridge-switchbot/src/settings.ts

Line 84 in 52d0f82

maxRetry?: number;

Most devices also seem to implement a retry method.

@donavanbecker donavanbecker moved this to BLE Issues in Homebridge Dec 12, 2022
@donavanbecker donavanbecker moved this from BLE Issues to BLE Feature Request in Homebridge Dec 12, 2022
@dnicolson dnicolson mentioned this issue Dec 27, 2022
Merged
@github-project-automation github-project-automation bot moved this from BLE Feature Request to Done in Homebridge Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Minsheng Minsheng

@donavanbecker donavanbecker

@chenliuyun chenliuyun

@SwitchBot SwitchBot

@SwitchBot-Wonderlabs SwitchBot-Wonderlabs

@Devin-Wonderlabs Devin-Wonderlabs

Labels
enhancement New feature or request
Projects
Homebridge
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max retry option for curtain
7 participants
@dnicolson @Minsheng @donavanbecker @chenliuyun @SwitchBot @SwitchBot-Wonderlabs @Devin-Wonderlabs