add support for Curtain 3 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks going to merge into beta branch |
donavanbecker
merged commit 8339db7
into
OpenWonderLabs:beta-1.9.2
10 of 12 checks passed
Merged
donavanbecker
added a commit
that referenced
this pull request
Jan 5, 2024
## [1.10.0](https://github.com/OpenWonderLabs/node-switchbot/releases/tag/v1.10.0) (2024-1-5) ## What's Changed - Fix reversed bot state reporting, Thanks [@grelca](https://github.com/grelca) [#207](#207) - Add support for Curtain 3, Thanks [@tsia](https://github.com/tsia) [#209](#209) - Housekeeping and update dependencies **Full Changelog**: v1.9.1...v1.10.0
donavanbecker
added a commit
that referenced
this pull request
Jan 5, 2024
## [1.10.0](https://github.com/OpenWonderLabs/node-switchbot/releases/tag/v1.10.0) (2024-1-5) ## What's Changed - Fix reversed bot state reporting, Thanks [@grelca](https://github.com/grelca) [#207](#207) - Add support for Curtain 3, Thanks [@tsia](https://github.com/tsia) [#209](#209) - Housekeeping and update dependencies **Full Changelog**: v1.9.1...v1.10.0
donavanbecker
added a commit
that referenced
this pull request
Jan 5, 2024
- Fix reversed bot state reporting, Thanks [@grelca](https://github.com/grelca) [#207](#207) - Add support for Curtain 3, Thanks [@tsia](https://github.com/tsia) [#209](#209) - Housekeeping and update dependencies **Full Changelog**: v1.9.1...v1.10.0
donavanbecker
added a commit
that referenced
this pull request
Jan 6, 2024
- Fix reversed bot state reporting, Thanks [@grelca](https://github.com/grelca) [#207](#207) - Add support for Curtain 3, Thanks [@tsia](https://github.com/tsia) [#209](#209) - Housekeeping and update dependencies **Full Changelog**: v1.9.1...v1.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Switchbot Curtain 3 is not supported.
💡 Proposed solution
Add optional Parameter to
open()andclose()methods to be passed through torunToPos()for QuietDrift supportAdd model identifier for Curtain 3
⚙️ Release Notes
Curtain 3 devices are now supported
➕ Additional Information
Testing
Reviewer Nudging