Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo implementation of EIP-4626 #277

Closed
FilipLaurentiu opened this issue Apr 16, 2022 · 5 comments · Fixed by #1170
Closed

Cairo implementation of EIP-4626 #277

FilipLaurentiu opened this issue Apr 16, 2022 · 5 comments · Fixed by #1170
Assignees
Milestone

Comments

@FilipLaurentiu
Copy link
Contributor

Full details of the standard
OpenZeppelin has always offered the best implementations for different standards in Ethereum and now in Starknet.
EIP-4626 it's the new popular standard for tokenized vaults and many projects already use it for their Vaults on Ethereum.

Starknet is becoming more and more popular and many projects need an implementation of this standard on which to rely. OZ has always provided well tested tools with no security issues.

An implementation from OZ would save a lot of development time and money

There are already two implementation for this standard in Cairo
https://github.com/koloz193/ERC4626
https://github.com/milancermak/cairo-4626

@EvolveArt
Copy link
Contributor

A few thoughts on this:

  • This implementation is more respectful of the standard
  • What do we think of using namespaces ? Sounds like a good thing to change everywhere tbh
  • Adding safemath would be great
  • We should use from starkware.cairo.common.bool import TRUE, FALSE if I'm looking correctly at latest changes
  • The storage_var should be called ERC4626_asset_ to fit OZ guidelines

@Pet3ris
Copy link

Pet3ris commented May 5, 2022

These implementations are awesome. Let me throw one more in the hat: https://github.com/auditless/cairo-erc4626

  • We follow the solmate impl.
  • Use TRUE, FALSE
  • Use ERC4626_ naming conventions

Like the idea of namespaces / safemath.

@Pet3ris
Copy link

Pet3ris commented May 24, 2022

@EvolveArt added your wishlist of safemath and namespaces:

https://github.com/auditless/cairo-erc4626

@martriay
Copy link
Contributor

martriay commented Jan 30, 2024

a reference implementation for Cairo 1: https://github.com/0xEniotna/ERC4626

@andrew-fleming andrew-fleming added this to the 4. later milestone Jun 15, 2024
@andrew-fleming andrew-fleming modified the milestones: 4. later, 3. after Aug 9, 2024
@VVander
Copy link

VVander commented Sep 7, 2024

Hello! Since STRK staking is coming soon, it would be great to have this moved up the priority list so that STRK LSTs can use it. Best we have at the moment is the ref impl mentioned above.

@andrew-fleming andrew-fleming self-assigned this Sep 24, 2024
@ggonzalez94 ggonzalez94 modified the milestones: 1. current, 2. next Oct 15, 2024
@andrew-fleming andrew-fleming modified the milestones: 2. next, 1. current Oct 18, 2024
@ericnordelo ericnordelo linked a pull request Jan 20, 2025 that will close this issue
3 tasks
@ericnordelo ericnordelo moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Jan 29, 2025
@andrew-fleming andrew-fleming mentioned this issue Jan 29, 2025
3 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Resolved
Status: No status
Development

Successfully merging a pull request may close this issue.

7 participants