Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

auto calculate max_fee #284

Closed
martriay opened this issue Nov 12, 2022 · 2 comments · Fixed by #332
Closed

auto calculate max_fee #284

martriay opened this issue Nov 12, 2022 · 2 comments · Fixed by #332
Assignees
Milestone

Comments

@martriay
Copy link
Contributor

instead of 0 as the default max_fee, nile should estimate the required fee for the users, which today have to guess it.

@martriay martriay moved this to 📋 Backlog in Cairo team Nov 12, 2022
@martriay martriay modified the milestones: next, later Nov 12, 2022
@martriay martriay modified the milestones: later, after, next Nov 21, 2022
@martriay martriay modified the milestones: next, current Dec 26, 2022
@ericnordelo
Copy link
Member

I think it could make sense to wait for #320 before adding this (and I think it will be easier to add too).

320 adds an estimate_fee abstraction for all the transactions, that can be used for this (I think that addressing this without that could cause a lot of unnecessary conflicts in code and tests).

IMO it can still be part of the same milestone, as long as we merge #320 first.

@andrew-fleming
Copy link
Contributor

Haha yeah, I stopped my progress after adding the implementation with account.send because of this. I'll checkout and work over the #320 PR. Thanks for the heads up, sir!

This was referenced Jan 2, 2023
@ericnordelo ericnordelo moved this from 📋 Backlog to 👀 In review in Cairo team Jan 5, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Resolved in Cairo team Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants