Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle_Destructible.html but no Destructible.sol #1486

Closed
godfreyhobbs opened this issue Oct 29, 2018 · 3 comments
Closed

lifecycle_Destructible.html but no Destructible.sol #1486

godfreyhobbs opened this issue Oct 29, 2018 · 3 comments
Labels
bug documentation Inline comments, guides, and examples.

Comments

@godfreyhobbs
Copy link

There is a doc https://openzeppelin.org/api/docs/lifecycle_Destructible.html but there is no code in 2.0

💻 Environment
Just looking at your docs

This is in 2.0 docs.
📝 Details
2.0 does not have a lifecycle_Destructible contract but there is still documentation.

Personally I would like to see a lifecycle/Destructible.sol in v2.0. I think it is a useful tool especially when doing iterations on testnet.

Just view https://openzeppelin.org/api/docs/lifecycle_Destructible.html then click on the link Source: lifecycle/Destructible.sol it opens up v1.12 NOT v2.0.

🔢 Code to reproduce bug

Look at the following, Destructible is not there:
https://github.com/OpenZeppelin/openzeppelin-solidity/tree/release-v2.0.0/contracts/lifecycle

@Aniket-Engg
Copy link
Contributor

Please Have a look: OpenZeppelin/openzeppelin-contracts-upgradeable#25

@frangio
Copy link
Contributor

frangio commented Nov 20, 2018

Hi @godfreyhobbs! It looks like a bug in our docs generation. That page shouldn't exist; note that Destructible is not in the sidebar for 2.0.0.

Please take a look at #1254 for the reasons for removing Destructible.

I think it is a useful tool especially when doing iterations on testnet.

This is a very interesting point. We removed the feature because we consider it dangerous on mainnet, but I can see how it can be useful in some testing workflows. I'll keep this in mind but unfortunately the other point is kind of a deal breaker.

@frangio frangio added bug documentation Inline comments, guides, and examples. labels Nov 20, 2018
@nventuro
Copy link
Contributor

The docsite has been revamped, and this bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Inline comments, guides, and examples.
Projects
None yet
Development

No branches or pull requests

4 participants