Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Destructible to receive an optional address to which to send funds #198

Closed
maraoz opened this issue Apr 20, 2017 · 2 comments
Closed

Allow Destructible to receive an optional address to which to send funds #198

maraoz opened this issue Apr 20, 2017 · 2 comments
Labels
good first issue Low hanging fruit for new contributors to get involved!

Comments

@maraoz
Copy link
Contributor

maraoz commented Apr 20, 2017

Instead of sending always to owner
@maraoz maraoz added the good first issue Low hanging fruit for new contributors to get involved! label Apr 20, 2017
@misteraverin
Copy link
Contributor

misteraverin commented Apr 30, 2017 •
edited
Loading

@maraoz Hi, I wanna work on this issue, but have question: in solidity we have no optional params to fucntions. Two ways to solve it:

  1. always add param to destroy function
  2. make another contract Destructible with param

Which is more preferebly?

@maraoz
Copy link
Contributor Author

maraoz commented May 3, 2017

@misteraverin thanks for taking this on. I think the best option is to add another method that receives a parameter, and leave the current one as is.

@misteraverin misteraverin mentioned this issue May 8, 2017
Merged
@Woodpile37 Woodpile37 mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maraoz @misteraverin