Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery for EIP712 signed typed data #2073

Closed
spalladino opened this issue Jan 30, 2020 · 2 comments
Closed

Recovery for EIP712 signed typed data #2073

spalladino opened this issue Jan 30, 2020 · 2 comments
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.

Comments

@spalladino
Copy link
Contributor

🧐 Motivation
EIP712 has been around for quite some time, and is already on v4. Metamask has support for it, making it much more transparent for an end user to understand what it is that they are signing. This recently came up as a request in the context of signing GSN meta-txs (by user ethicraul), which greatly improves the UX of the signing request - to the point that OpenEth is integrating this scheme into GSN v2.

📝 Details
The current ecrecover library only provides support for hashing data into the Ethereum Signed Message format. We should add methods that simplify the verification of data signed with typed data v4. See here for the implementation built by OpenEth as an example, or here for the implementation built into the DAI ERC20.
@spalladino spalladino changed the title Address recovery for EIP712 signed typed data Recovery for EIP712 signed typed data Jan 30, 2020
@abcoathup abcoathup added contracts Smart contract code. feature New contracts, functions, or helpers. labels Jan 31, 2020
@frangio
Copy link
Contributor

frangio commented Jan 31, 2020

This may be a duplicate of #1810.

@frangio
Copy link
Contributor

frangio commented Aug 6, 2021

I think this is resolved now since we have helpers for EIP712.

@frangio frangio closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spalladino @frangio @abcoathup