Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant lockfiles (npm and yarn) #284

Closed
frangio opened this issue Jun 30, 2017 · 4 comments · Fixed by #585
Closed

Redundant lockfiles (npm and yarn) #284

frangio opened this issue Jun 30, 2017 · 4 comments · Fixed by #585

Comments

@frangio
Copy link
Contributor

frangio commented Jun 30, 2017

There's already a yarn.lock file in the repository. It's not clear if we should also add npm5's package-lock.json.

See update below.

@frangio
Copy link
Contributor Author

frangio commented Jul 21, 2017

Keeping an eye on yarnpkg/yarn#3614. We're not the only ones confused by this. 🙂

@frangio
Copy link
Contributor Author

frangio commented Aug 12, 2017

There are now both yarn.lock and package-lock.json files in the repository. They are kept in sync via yarn import after #363.

@frangio frangio changed the title Add npm package-lock.json Redundant lockfiles (npm and yarn) Aug 12, 2017
@shrugs
Copy link
Contributor

shrugs commented Nov 24, 2017

We should probably pick one and enforce its usage. I'm pretty ambivalent about which one the project chooses, but having both seems unnecessary. I can put out a PR for this later if we've made a decision.

@frangio
Copy link
Contributor Author

frangio commented Nov 27, 2017

Currently yarn is used in Travis, but most of us use npm locally. Travis was set up to use yarn in #250 because of performance reasons.

I'd be in favor of moving to npm completely and removing yarn.lock, now that npm 5 is more performant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants