-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Initializable #3450
Merged
Merged
Simplify Initializable #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
reviewed
Jun 3, 2022
Amxx
reviewed
Jun 3, 2022
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx
approved these changes
Jun 3, 2022
tynes
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jul 28, 2022
Standardize on the upgradable initializable since the contracts are technically upgradable it is more clear. There are no real implementation differences between the upgradable and standard initializable implementations. `OwnableUpgradable` is `initializable` imported from the upgradable package, and the `L2OutputOracle` inherits from `OwnableUpgradable`. This means that the only way to standardize on a single implementation of `Initializable` is to use the upgradable version. This also bumps the version of the openzeppelin contracts dependency because they refactored the initializable implementation and made it easier to understand. https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/releases/tag/v4.7.0 OpenZeppelin/openzeppelin-contracts#3450
mergify bot
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jul 28, 2022
* contracts-bedrock: fix build Standardize on the upgradable initializable since the contracts are technically upgradable it is more clear. There are no real implementation differences between the upgradable and standard initializable implementations. `OwnableUpgradable` is `initializable` imported from the upgradable package, and the `L2OutputOracle` inherits from `OwnableUpgradable`. This means that the only way to standardize on a single implementation of `Initializable` is to use the upgradable version. This also bumps the version of the openzeppelin contracts dependency because they refactored the initializable implementation and made it easier to understand. https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/releases/tag/v4.7.0 OpenZeppelin/openzeppelin-contracts#3450 * op-bindings: regenerate
maurelian
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Sep 15, 2022
* contracts-bedrock: fix build Standardize on the upgradable initializable since the contracts are technically upgradable it is more clear. There are no real implementation differences between the upgradable and standard initializable implementations. `OwnableUpgradable` is `initializable` imported from the upgradable package, and the `L2OutputOracle` inherits from `OwnableUpgradable`. This means that the only way to standardize on a single implementation of `Initializable` is to use the upgradable version. This also bumps the version of the openzeppelin contracts dependency because they refactored the initializable implementation and made it easier to understand. https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/releases/tag/v4.7.0 OpenZeppelin/openzeppelin-contracts#3450 * op-bindings: regenerate
sam-goldman
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Sep 15, 2022
* contracts-bedrock: fix build Standardize on the upgradable initializable since the contracts are technically upgradable it is more clear. There are no real implementation differences between the upgradable and standard initializable implementations. `OwnableUpgradable` is `initializable` imported from the upgradable package, and the `L2OutputOracle` inherits from `OwnableUpgradable`. This means that the only way to standardize on a single implementation of `Initializable` is to use the upgradable version. This also bumps the version of the openzeppelin contracts dependency because they refactored the initializable implementation and made it easier to understand. https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/releases/tag/v4.7.0 OpenZeppelin/openzeppelin-contracts#3450 * op-bindings: regenerate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3344 we introduced changes to Initializable in order to enable the use of
_disableInitializers()
in the constructor of multiple parents:However, the resulting code was difficult to reason about, and it introduced a bug when mixing
_disableInitializers
and the old patternconstructor() initializer {}
.We sat down to rethink it and trim it down to more straightforward code.
This PR slightly changes how functions with the
initializer
andreinitializer
modifiers can be nested in the context of the constructor.initializer
functions work the same as 4.6: they can be nested in this context. This is present for backwards compatibility with versions prior to 4.4.1 and we may remove it in 5.0.reinitializer
functions can't be nested. If one is invoked in the context of another, it will revert. This is a small breaking change forreinitializer(1)
. We don't think anyone will be affected by this change given that reinitializers were released only 1 month ago and the broken pattern was not a recommended one. It allows us to make the code much simpler.