Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes zero address check from balanceOf in ERC1155 #4263

Conversation

balajipachai
Copy link
Contributor

@balajipachai balajipachai commented May 19, 2023

  • updates ERC1155 contract and tests
  • removes address zero check from balanceOf function
  • makes necessary changes in the ERC1155.test.js file
  • ensures all tests are passing

Fixes #4259
Fixes LIB-871

PR Checklist

  • [All are passing] Tests
  • [None] Documentation
  • [None] Changeset entry (run npx changeset add)

* updates ERC1155 contract and tests
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: b0f2fd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented May 22, 2023

Thank you @balajipachai for this PR.
This needs a changeset. Otherwize its good IMO

@frangio frangio changed the title Removes zero address check from balanceOf function in ERC1155 contract Removes zero address check from balanceOf in ERC1155 May 23, 2023
@frangio frangio requested a review from Amxx May 23, 2023 22:42
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amxx Amxx enabled auto-merge (squash) May 24, 2023 08:17
@Amxx Amxx merged commit cbc6145 into OpenZeppelin:master May 24, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented May 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove check for address zero in ERC1155.balanceOf
3 participants