Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getRoleMembers method to return all accounts that have role #4546

Merged

Conversation

vlad-khramov
Copy link
Contributor

AccessControlEnumerable uses AddressSet for storing accounts that have certain role. AddressSet has very convenient method values to return all elements of the set, but it wan't used in AccessControlEnumerable.

Since values is recommened to use only in view calls, original warning was also added to documentation of getRoleMembers method

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: c405a44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Amxx
Amxx previously approved these changes Dec 19, 2023
@Amxx Amxx requested a review from ernestognw December 19, 2023 14:23
@Amxx Amxx added the feature New contracts, functions, or helpers. label Dec 19, 2023
@Amxx Amxx added this to the 5.1 milestone Dec 19, 2023
ernestognw
ernestognw previously approved these changes Dec 19, 2023
.changeset/violet-moons-tell.md Outdated Show resolved Hide resolved
@ernestognw ernestognw dismissed stale reviews from Amxx and themself via 513a104 December 19, 2023 20:20
ernestognw
ernestognw previously approved these changes Dec 19, 2023
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestognw ernestognw enabled auto-merge (squash) December 19, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New contracts, functions, or helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants