-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Misleading Typo in CHANGELOG.md related to false solidity version #4697
Conversation
|
Hello @0xprinc I don't understand this requested change. All files in the release branch use The only file in our codebase that doesn't use this pragma is |
Hello sir, Actually this typo got me to get false insights about the smart contract I was doing security analysis of. |
I think there is a missunderstanding here. Yes, the PR #4288 did update the minimum version to 0.8.19 ... but then we did another PR that changed that to 0.8.20. Maybe we should change the PR link to the latest one (the one that targets 0.8.20). |
CHANGELOG.md
Outdated
@@ -48,7 +48,7 @@ These removals were implemented in the following PRs: [#3637](https://github.com | |||
#### General | |||
|
|||
- Replaced revert strings and require statements with custom errors. ([#4261](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4261)) | |||
- Bumped minimum compiler version required to 0.8.20 ([#4288](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4288)) | |||
- Bumped minimum compiler version required to 0.8.19 ([#4288](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4288)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Bumped minimum compiler version required to 0.8.19 ([#4288](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4288)) | |
- Bumped minimum compiler version required to 0.8.20 ([#4489](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4489)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reference both PRs in my opinion.
- Bumped minimum compiler version required to 0.8.19 ([#4288](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4288)) | |
- Bumped minimum compiler version required to 0.8.20 ([#4489](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4489)) ([#4288](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4288)) |
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Thanks! |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 OpenZeppelin Contracts Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Fixes #????
PR Checklist
npx changeset add
)