Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documented requirement in IERC1155's balanceOf #4847

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

andrew-fleming
Copy link
Contributor

The zero address check was removed from ERC1155's balanceOf in #4263; however, the documentation still displays the non-zero address as a requirement. This PR proposes to fix that.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jan 19, 2024

⚠️ No Changeset found

Latest commit: c6eb3df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx merged commit e5c6363 into OpenZeppelin:master Jan 19, 2024
21 of 22 checks passed
@andrew-fleming andrew-fleming deleted the remove-balanceof-comment branch January 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants