Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refundable post delivery crowdsale #1543

Merged

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Dec 6, 2018

Fixes #877

Since this is a PostDeliveryCrowdsale, tokens will only be granted after it ends, and only if the crowdsale is successful (i.e. the goal is met): therefore, the tokens being issued and purchases being refunded become mutually exclusive scenarios, preventing the issue described.

I made the new crowdsale inherit from RefundableCrowdsale, but if we chose to deprecate it (i.e. pragma deprecated or something along those lines) we will probably want to copy the logic into this new contract.

@nventuro nventuro added kind:improvement contracts Smart contract code. labels Dec 6, 2018
@nventuro nventuro added this to the v2.1 milestone Dec 6, 2018
@nventuro nventuro self-assigned this Dec 6, 2018
@nventuro nventuro requested a review from frangio December 6, 2018 12:21
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@frangio
Copy link
Contributor

frangio commented Dec 11, 2018

In this PR we should also add the warning (the "deprecation warning") in RefundableCrowdsale.

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frangio frangio merged commit 357fded into OpenZeppelin:master Dec 11, 2018
@nventuro nventuro deleted the refundable-post-delivery-crowdsale branch December 11, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants