Add a vault to PostDeliveryCrowdsale. #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Apr 22, 2019
frangio
reviewed
Apr 22, 2019
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1595.
PostDeliveryCrowdsalepostpones the moment in which_deliverTokensis called until withdrawal time, which cause validation issues. For example,AllowanceCrowdsalecallstransferFromon_deliverTokens, so there are no guarantees that the tokens will actually be there once the crowdsale ends. Additionally, because the allowance was not being used, the number of tokens remaining was not updated. A similar scenario happens on aMintedCrowdsalewith anERC20Cappedtoken.This fixes that by calling
_deliverTokensat the moment of purchase, transferring them to a contract that will hold them untilPostDeliveryallows for withdrawal (a mini token escrow).