Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware-testing): add __init__.py to modules/ so it gets packed in the build + other Flex stacker QC fixes. #16995

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Nov 27, 2024

Overview

Sdist does not package non-module directories, so lets add an __init__.py so it does, this will make it so we can push to the robot. Fix some additional issues found while testing the Flex stacker QC script.

Test Plan and Hands on Testing

  • Make sure we can use push-ot3 and run the flex_stacker_qc_script from the flex robot.
  • Makes sure the flex_stacker_qc_script run successfully and on a real Flex-stacker

Changelog

  • add __init__.py to /modules dir
  • change the way we validate no movement when in e-stop
  • don't wait for ack from stop_motor M0 command.

Review requests

Risk assessment

@vegano1 vegano1 requested a review from a team as a code owner November 27, 2024 17:00
@vegano1 vegano1 changed the title fix(hardware-testing): add __init__.py to modules/ so it gets packed in the build. fix(hardware-testing): add __init__.py to modules/ so it gets packed in the build + other Flex stacker QC fixes. Nov 27, 2024
Copy link
Contributor

@djgomez-opentrons djgomez-opentrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on 2 stackers, works

@vegano1 vegano1 merged commit 2b4e657 into edge Nov 27, 2024
6 checks passed
@vegano1 vegano1 deleted the add-modules-init branch November 27, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants