You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's almost certainly a better abstraction for test_algolia_exception_error and test_algolia_unreachable_host_error because they are the exact same test, just with different fake errors returned from algolia. Someone can go in and abstract out the similarities and perhaps inject the mocks just where they're needed to cut down on the code and/or execution time. See Refactors test_routes as a separate module #266 (comment)
We were never able to implement test_false_validation due to problems mocking the correct function. I'm not sure if it was our implementation or perhaps a bug in pytest-mock, but it just wasn't working for us. If you can make it work, we'd love this test to exist. See Refactors test_routes as a separate module #266 (comment)
The text was updated successfully, but these errors were encountered:
In #266 we made a lot of improvement on the tests, but we had to throw in the towel on a few of the issues:
The
search
tests might not be testing anything. See Refactors test_routes as a separate module #266 (comment)There's almost certainly a better abstraction for
test_algolia_exception_error
andtest_algolia_unreachable_host_error
because they are the exact same test, just with different fake errors returned from algolia. Someone can go in and abstract out the similarities and perhaps inject the mocks just where they're needed to cut down on the code and/or execution time. See Refactors test_routes as a separate module #266 (comment)We were never able to implement
test_false_validation
due to problems mocking the correct function. I'm not sure if it was our implementation or perhaps a bug in pytest-mock, but it just wasn't working for us. If you can make it work, we'd love this test to exist. See Refactors test_routes as a separate module #266 (comment)The text was updated successfully, but these errors were encountered: