From e31014f789deeda866f07a8a9a0bde6f63a72c22 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Mon, 23 May 2022 14:42:27 +0200 Subject: [PATCH] Remarks in `//` or `` --- scss/_navbar.scss | 2 +- site/assets/js/code-examples.js | 7 ------ site/assets/scss/_clipboard-js.scss | 20 +++------------- site/assets/scss/_content.scss | 7 +----- site/assets/scss/_layout.scss | 5 ---- site/assets/scss/_masthead.scss | 6 ----- site/assets/scss/_navbar.scss | 33 ++++++++++---------------- site/assets/scss/_sidebar.scss | 15 +++--------- site/layouts/partials/docs-subnav.html | 4 +--- site/layouts/shortcodes/example.html | 23 +----------------- 10 files changed, 23 insertions(+), 99 deletions(-) diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 61d8524889..0bec7d7f6b 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -455,7 +455,7 @@ ////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////// - // TODO: Is it really useful in Boosted? + // TODO: Is it really useful in Boosted? - LMP: I would to have better Bootstrap compatibility ? However, doesn't change anything IMO ////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////// .offcanvas { diff --git a/site/assets/js/code-examples.js b/site/assets/js/code-examples.js index 0c1f2eb3f8..222da1ce13 100644 --- a/site/assets/js/code-examples.js +++ b/site/assets/js/code-examples.js @@ -18,13 +18,6 @@ const btnTitle = 'Copy to clipboard' const btnEdit = 'Edit on StackBlitz' - // //////////////////////////////////////////////////////// - // //////////////////////////////////////////////////////// - // TODO: Bootstrap can remove width, height and - // fill="currentColor" of ', diff --git a/site/assets/scss/_clipboard-js.scss b/site/assets/scss/_clipboard-js.scss index 58348995a7..74ec070093 100644 --- a/site/assets/scss/_clipboard-js.scss +++ b/site/assets/scss/_clipboard-js.scss @@ -29,7 +29,7 @@ //////////////////////////////////////////////////////// //////////////////////////////////////////////////////// - // TODO: see if we can't use a btn-* class instead + // TODO: see if we can't use a btn-* class instead - LMP: Check comments, but IMO hard to do //////////////////////////////////////////////////////// //////////////////////////////////////////////////////// &:hover { @@ -51,24 +51,10 @@ .btn-clipboard { position: relative; z-index: 2; - //////////////////////////////////////////////////////// - //////////////////////////////////////////////////////// - // TODO: check all cases - // TODO: see if we can't use $border-something - // TODO: px >>> rem - //////////////////////////////////////////////////////// - //////////////////////////////////////////////////////// - margin-top: 2px; // Boosted mod - margin-right: 2px; // Boosted mod + margin-top: $border-width; // Boosted mod + margin-right: $border-width; // Boosted mod } -//////////////////////////////////////////////////////// -//////////////////////////////////////////////////////// -// Boosted mod: removed it in favor of using utility classes -// in shortcodes > example.html -//////////////////////////////////////////////////////// -//////////////////////////////////////////////////////// - /* .highlight-toolbar { .btn-clipboard { margin-top: 0; diff --git a/site/assets/scss/_content.scss b/site/assets/scss/_content.scss index 1276c183f2..1a3200fb6b 100644 --- a/site/assets/scss/_content.scss +++ b/site/assets/scss/_content.scss @@ -101,11 +101,6 @@ fill: currentcolor; } -///////////////////////////////////////////////////////////////// -///////////////////////////////////////////////////////////////// -// TODO: test into Bootstrap if there's not a conflict with .icon-link in features.css -///////////////////////////////////////////////////////////////// -///////////////////////////////////////////////////////////////// .icon-link { display: flex; align-items: center; @@ -121,7 +116,7 @@ ///////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////// - // TODO: Do we keep this animation in Boosted? + // TODO: Do we keep this animation in Boosted? - LMP: IMO, make the homepage a bit more attractive ///////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////// &:hover { diff --git a/site/assets/scss/_layout.scss b/site/assets/scss/_layout.scss index 527dd85a9e..67a9efc1ea 100644 --- a/site/assets/scss/_layout.scss +++ b/site/assets/scss/_layout.scss @@ -1,8 +1,3 @@ -/////////////////////////////////////////////// -/////////////////////////////////////////////// -// TODO: check me! Not sure what's the purpose of --bs-gutter-x -/////////////////////////////////////////////// -/////////////////////////////////////////////// .bd-gutter { --bs-gutter-x: #{$bd-gutter-x * 2}; diff --git a/site/assets/scss/_masthead.scss b/site/assets/scss/_masthead.scss index 8c91344eec..001e07924f 100644 --- a/site/assets/scss/_masthead.scss +++ b/site/assets/scss/_masthead.scss @@ -71,10 +71,4 @@ } } -/////////////////////////////////////////////////////////// -/////////////////////////////////////////////////////////// -// Boosted mod: no .masthead-followup-svg // Boosted mod: no .masthead-notice -// TODO: check if it's the case in Bootstrap as well -/////////////////////////////////////////////////////////// -/////////////////////////////////////////////////////////// diff --git a/site/assets/scss/_navbar.scss b/site/assets/scss/_navbar.scss index a35afd3745..80fbed1d97 100644 --- a/site/assets/scss/_navbar.scss +++ b/site/assets/scss/_navbar.scss @@ -1,29 +1,14 @@ -///////////////////////////////////////////////////////////////////////////////// -///////////////////////////////////////////////////////////////////////////////// -// TODO: check all those rules but normally we wouldn't need anything in this file -///////////////////////////////////////////////////////////////////////////////// -///////////////////////////////////////////////////////////////////////////////// .bd-navbar { // Boosted mod: no padding - background-color: transparent; + // Boosted mod: no background-color // Boosted mod: no background-image // Boosted mod: no box-shadow - // Boosted mod: no .navbar-toggler - - // Boosted mod - .navbar-nav.flex-row { - @include media-breakpoint-down(lg) { - border-top: 1px solid #666; - } - } - // End mod - // Boosted mod: no .navbar-brand - .navbar-toggler, - .nav-link { - display: block; // Boosted mod: no padding, no color + // Boosted mod: no .navbar-toggler + .nav-link { // Boosted mod: Needed since the dropdowns define their own color (could be removed once they are tackled) + // Boosted mod: no display, no padding, no color &:hover, &:focus { @@ -31,7 +16,7 @@ } &.active { - font-weight: 600; + // Boosted mod: no font-weight color: var(--#{$prefix}link-hover-color); // Boosted mod } } @@ -56,4 +41,12 @@ background-position: right $dropdown-item-padding-x top .75rem; // Boosted mod background-size: .75rem .75rem; } + + // Boosted mod: Specificity + .navbar-nav.flex-row { + @include media-breakpoint-down(lg) { + border-top: 1px solid #666; + } + } + // End mod } diff --git a/site/assets/scss/_sidebar.scss b/site/assets/scss/_sidebar.scss index 9e13fc60f1..a31d9e2899 100644 --- a/site/assets/scss/_sidebar.scss +++ b/site/assets/scss/_sidebar.scss @@ -35,12 +35,7 @@ .bd-links-link { padding: .1875rem .5rem; margin-top: .125rem; - ////////////////////////////////////////////////////////////////////////////// - ////////////////////////////////////////////////////////////////////////////// - // TODO: adapt this rule after having changed the size of icons - ////////////////////////////////////////////////////////////////////////////// - ////////////////////////////////////////////////////////////////////////////// - margin-left: 1.125rem; // Boosted mod: changed value + margin-left: 1.375rem; // Boosted mod: changed value color: rgba($black, .65); text-decoration: if($link-decoration == none, null, none); @@ -52,11 +47,7 @@ } // Boosted mod -.bd-links-heading { - transform: translateX(-#{$spacer * .25}); - - svg { - font-size: 1.5625rem; - } +.bd-links-heading svg { + font-size: 1.5625rem; } // End mod diff --git a/site/layouts/partials/docs-subnav.html b/site/layouts/partials/docs-subnav.html index bc77b069ff..68a274a97c 100644 --- a/site/layouts/partials/docs-subnav.html +++ b/site/layouts/partials/docs-subnav.html @@ -5,9 +5,7 @@
{{- $lang -}}
- - - - - - - - - - - - - - - - -