Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Call, Request, Response public #1548

Closed
jcamiel opened this issue May 16, 2023 · 0 comments
Closed

Make Call, Request, Response public #1548

jcamiel opened this issue May 16, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented May 16, 2023

In Hurl 3.0.0, the public method run returns a Result<HurlResult, String>.

In the graph structs, there are private structs Call, Request, Response:

pub struct HurlResult {
    pub entries: Vec<EntryResult>,
    pub time_in_ms: u128,
    //...
}
pub struct EntryResult {
    pub entry_index: usize,
    pub calls: Vec<Call>,
    pub captures: Vec<CaptureResult>,
   //...
}
pub struct Call {
    pub request: Request,
    pub response: Response,
    pub timings: Timings,
}

The types Call, Request, Response should be public and exported by the crate hurl.

@jcamiel jcamiel added the bug Something isn't working label May 16, 2023
@jcamiel jcamiel added this to the 3.1.0 milestone May 16, 2023
@jcamiel jcamiel closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant