Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra debug logs for request header when posting large body #1651

Closed
jcamiel opened this issue Jun 16, 2023 · 0 comments · Fixed by #1652
Closed

Extra debug logs for request header when posting large body #1651

jcamiel opened this issue Jun 16, 2023 · 0 comments · Fixed by #1652
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented Jun 16, 2023

What is the current bug behavior?

Given a 15M file, with this Hurl file (using verbose option):

POST http://localhost:8000/post_large
Content-Type: application/octet-stream
[Options]
verbose: true
file,post_large.bin;

The current output is:

* Options:
*     fail fast: true
*     follow redirect: false
*     insecure: false
*     max redirect: 50
*     retry: 0
* ------------------------------------------------------------------------------
* Executing entry 1
*
* Cookie store:
*
* Request:
* POST http://localhost:8000/post_large
* Content-Type: application/octet-stream
*
* Request can be run with the following curl command:
* curl --header 'Content-Type: application/octet-stream' --data '@tests_ok/post_large.bin' 'http://localhost:8000/post_large'
*
> POST /post_large HTTP/1.1
> Host: localhost:8000
> Accept: */*
> Content-Type: application/octet-stream
> User-Agent: hurl/4.0.0-SNAPSHOT
> Content-Length: 15728640
>
> Host: localhost:8000
> Accept: */*
> Content-Type: application/octet-stream
> User-Agent: hurl/4.0.0-SNAPSHOT
> Content-Length: 15728640
>
> Host: localhost:8000
> Accept: */*
> Content-Type: application/octet-stream
> User-Agent: hurl/4.0.0-SNAPSHOT
> Content-Length: 15728640
>
> Host: localhost:8000
> Accept: */*
> Content-Type: application/octet-stream
> User-Agent: hurl/4.0.0-SNAPSHOT
> Content-Length: 15728640
>
> Host: localhost:8000
> Accept: */*
> Content-Type: application/octet-stream
> User-Agent: hurl/4.0.0-SNAPSHOT
> Content-Length: 15728640
....
>
> Host: localhost:8000
> Accept: */*
> Content-Type: application/octet-stream
> User-Agent: hurl/4.0.0-SNAPSHOT
> Content-Length: 15728640
>
* Response: (received 8 bytes in 38 ms)
*
< HTTP/1.1 200 OK
< Server: Werkzeug/2.3.3 Python/3.11.3
< Date: Fri, 16 Jun 2023 11:08:44 GMT
< Content-Type: text/html; charset=utf-8
< Content-Length: 8
< Server: Flask Server
< Connection: close
<

The request headers are logged multiple times. It's only a log bug: on the nework, only the right number of headers is sent.

What is the expected correct behavior?

Log the exact number of request headers.

Execution context

  • Hurl Version (hurl --version):
  • Operating system and version:

hurl 3.0.0 libcurl/7.79.1 (SecureTransport) LibreSSL/3.3.6 zlib/1.2.11 nghttp2/1.45.1
Features (libcurl): alt-svc AsynchDNS HSTS HTTP2 IPv6 Largefile libz NTLM NTLM_WB SPNEGO SSL UnixSockets
Features (built-in): brotli

Possible fixes

@jcamiel jcamiel added the bug Something isn't working label Jun 16, 2023
@jcamiel jcamiel self-assigned this Jun 16, 2023
@jcamiel jcamiel added this to the 4.0.0 milestone Jun 16, 2023
@jcamiel jcamiel linked a pull request Jun 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant