Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings for all targets #3666

Closed
wants to merge 1 commit into from

Conversation

Goffen
Copy link

@Goffen Goffen commented Jan 29, 2025

Fix for all lint warnings #3665. Using clippy 0.1.84 (current rust stable)

@Goffen Goffen force-pushed the fix-clippy-0.1.84 branch 2 times, most recently from a3295ed to a8096aa Compare January 29, 2025 14:55
@Goffen
Copy link
Author

Goffen commented Jan 29, 2025

trying to sign it, but that is apparently not easy

@jcamiel
Copy link
Collaborator

jcamiel commented Jan 29, 2025

Hi @Goffen we've set some links see in the CONTRIBUTING guide to see how sign your commits:

check

I'll change our CI/CD check so we pass clippy on the test target also.

@jcamiel
Copy link
Collaborator

jcamiel commented Jan 29, 2025

@Goffen when I click on your commit I see a "Unverified" tag with this warning:

unverified

@Goffen Goffen force-pushed the fix-clippy-0.1.84 branch from a8096aa to 85c3f0a Compare January 29, 2025 18:47
@jcamiel
Copy link
Collaborator

jcamiel commented Jan 30, 2025

Hi @Goffen tell me if you struggle to sign your commit, I'll make the change in another PR

@Goffen
Copy link
Author

Goffen commented Jan 30, 2025

Ah yes cant for the love of god sign stuff. Testing out with new commits aswell. I wanted to test out a solution to a problem I have in this repo and got annoyed about the warnings.
So yes, closing this PR and you can go ahead and fix in your.
Sorry for the trouble

@Goffen Goffen closed this Jan 30, 2025
@jcamiel
Copy link
Collaborator

jcamiel commented Jan 31, 2025

@Goffen clippy warnings are fixed now and check in the CI/CD for all targets. Thanks for having raised the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants