sdba - Grouped detrending #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huard
reviewed
May 28, 2020
huard
requested changes
May 28, 2020
Pull Request Test Coverage Report for Build 1974
💛 - Coveralls |
This was referenced May 29, 2020
Open
huard
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (minor / major / patch)has been called on this branchgit push --tags)All detrending is now made using the
Grouperclass of sdba. The BaseDetrend exposed methods callgroup.apply()with the_fitand_get_trendmethods of the subclasses.Performance could be lower for simple detrendings. To code it as elegantly as I could, I didn't code shortcuts. When calling
fit, the_fit(da)method returns a grouped dataset. This dataset is broadcasted back along the 'time' coordinate of the dataarray to detrend and then grouped again for the trend computation (which is a non-grouping grouped operation). For something as simple asMeanDetrendit's a lot of overhead...Yes, in order to achieve this as elegantly as I could, I removed the resampling possibility of
PolyDetrend. It could be put back, but it's slightly more complicated. Watcha think @huard?Results of DQM might be different between this new method and the previous one.
EDIT: Comment on the performance
Might not work with the current master of xarray : calling
polyfiton an element fromgroupbycould throw some errors that should be fixed with Allow non-unique and non-monotonic coordinates in get_clean_interp_index and polyfit pydata/xarray#4099.