-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Propose v/1.4.0 | ⚡ Few Improvements | ➖ Drop dependencies to reduce the footprint #41
Conversation
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 84.56% 83.76% -0.81%
==========================================
Files 13 14 +1
Lines 920 967 +47
==========================================
+ Hits 778 810 +32
- Misses 142 157 +15
Continue to review full report at Codecov.
|
… + ASCII detection review ASCII until proven otherwise
…g functions to be imported as is
…unravel suspicious CJK usage
…ter dragonmapper drop
For now, we observe a slight decrease in Chinese-related CP detection. Should be fixed soon. Thinking of ways to resolve this. |
Otherwise,
|
Changes :
logging
instead of using the packageloguru
.nose
test framework in favor of the maintainedpytest
.dragonmapper
package to help with gibberish Chinese/CJK text. Prefer using characters occurrences instead.cached_property
only for Python 3.5 due to constraint. Dropping for every other interpreter version.CharsetNormalizerMatch
instance could beFalse
in rare case even if obviously present. Due to the sub-match factoring process.