Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use !Default for sass variables #153

Open
Solinx opened this issue Sep 3, 2017 · 0 comments
Open

Use !Default for sass variables #153

Solinx opened this issue Sep 3, 2017 · 0 comments

Comments

@Solinx
Copy link

Solinx commented Sep 3, 2017 •
edited
Loading

Please add !default to each sass variable. It allows us to override these values without having to touch the framework code. See: https://robots.thoughtbot.com/sass-default

A related issue: Could you use a namespace for your variables? Like $amazium-...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Solinx