Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-async loading of featuredInstances.json5 #179

Open
mblomdahl opened this issue Oct 1, 2024 · 0 comments
Open

Non-async loading of featuredInstances.json5 #179

mblomdahl opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mblomdahl
Copy link
Contributor

mblomdahl commented Oct 1, 2024

As discovered in #177, it is tricky to import a JSON5 file as you'd module-import a JSON (as we did before). I would like to return to having the featuredInstances.json5 imported as a module somehow. I've tried all the suggestions in the Using JSON5 with TypeScript documentation page, but everything failed. Instead, I would propose we have a pre-processing step (maybe a prepare script in the package.json?) that is responsible for always converting the featuredInstances.json5 → (type-validated) featuredInstances.json before starting/building/running the application. This would allow us to simply import featuredInstances from "../featured-instances.json" as before in the application.

@mblomdahl mblomdahl added enhancement New feature or request help wanted Extra attention is needed labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant